Finalised write aseg gdf function #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2ray
requested changes
Feb 23, 2024
There was a problem hiding this comment.
Nicely done.
Next time, please provide an MWE (minimum working example) to aid reviewing as follows:
using HiQGA
vall=[[1, [2., 3.]], [2, [3., 4.]]]
sfmt = ["%3d", "%4.1f"]
outfile = "myfile"
channel_names = [["FID", "dBz/dt"], ["","pV/Am4"],["FID", "dBz/dt"]]
transD_GP.CommonToAll.writeaseggdf(vall, sfmt, outfile, channel_names)- please check if output f above MWE works in Geosoft, especially checking if providing no unit name is problematic. Add a screenshot here to confirm ok.
- lastly, please check review comments on making standalone functions for the DFN file writer.
Comment on lines
+2012
to
+2023
| sfmt_fortran = Vector{String}(undef, length(sfmt)) | ||
|
|
||
| for i =1:length(sfmt) | ||
| temp1 = last(sfmt[i], 1) | ||
| temp1 = uppercase(temp1) | ||
| temp2 = strip(sfmt[i], '%') | ||
|
|
||
| fortran_format = string(temp1, temp2) | ||
| fortran_format = chop(fortran_format) | ||
|
|
||
| sfmt_fortran[i] = fortran_format | ||
| end |
There was a problem hiding this comment.
Please make the fortran format creator a standalone function which can be re-used
src/CommonToAll.jl
Outdated
Comment on lines
2025
to
2040
| ##Write the definition file | ||
| open(outfile*".dfn", "w") do io | ||
| #println(io, "DEFN ST=RECD,RT=COMM;RT:A4;COMMENTS:A76") #Geosoft | ||
|
|
||
| for i=1:length(channel_names[1]) | ||
| if (length(vall[1][i]) == 1) | ||
| println(io, "DEFN $(i) ST=RECD,RT=; $(channel_names[1][i]): $(sfmt_fortran[i]) : NULL=-99999.99, UNITS=$(channel_names[2][i]), LONGNAME=$(channel_names[3][i])") | ||
| else | ||
| println(io, "DEFN $(i) ST=RECD,RT=; $(channel_names[1][i]): $(record[i])$(sfmt_fortran[i]) : NULL=-99999.99, UNITS=$(channel_names[2][i]), LONGNAME=$(channel_names[3][i])") | ||
| end | ||
| end | ||
|
|
||
| println(io, "DEFN $(length(channel_names[1])+1) ST=RECD,RT=; END DEFN") | ||
| flush(io) | ||
| close(io) | ||
| end |
There was a problem hiding this comment.
Please make the DFN writer into a standalone function for re-usability. Also, please check whitespace formatting. close should be tabbed from end and open
There was a problem hiding this comment.
Done please see screenshot of geosoft import
added 4 commits
February 26, 2024 15:03
-split functions for .dat and .dfn file -created fortran formatter for field codes -created a test file
-split functions for .dat and .dfn file -created fortran formatter for field codes -created a test file
ensure that line field is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two functions added. Generic field names removed. Function can write the ASEG GDF format .dat and .dfn files based on fname supplied as a user string.