Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master branch update post 2024.5 Official release #4037

Merged
merged 81 commits into from
Dec 12, 2024

Conversation

Maheshkale447
Copy link
Contributor

@Maheshkale447 Maheshkale447 commented Dec 12, 2024

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve all Codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Update the Help Library document to match any feature changes

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced error handling for ALM project connections and item exports.
    • Improved UI responsiveness and visibility management in action editing components.
    • Added dialog listening capabilities in browser interaction classes.
  • Bug Fixes

    • Fixed potential null reference issues in various methods across the application.
    • Refined checks for unique parameter names in the model parameters page.
  • Documentation

    • Added license headers to multiple files.
  • Refactor

    • Streamlined connection handling and database interaction logic.
    • Improved code organization and readability in several classes.
  • Tests

    • Introduced new unit tests for equality logic in Activity and BusinessFlow classes.

Maheshkale447 and others added 30 commits December 1, 2024 23:39
Pre  officia release branch sync with master branch
…izardDisableFinish

BugFix - 43100 - Disabled finish button on "Import POM from Katalon Object Repository Wizard"
GingerOps Next button giving error when clicking on it without select…
Playwright Defect fix D43161_D43162_D44142_D44141
…riable

Handled the env, Activity, BF level variable
…oryFix

D43121_ RQM Category and Custom attributes update fix
Maheshkale447 and others added 28 commits December 10, 2024 16:33
Fix - Defect Creation Through CLI and Add Attachment
…ectingIn_POM

Bug fix/39866 TA selecting in POM Page
implement connection string decryption for ginger play
Copy link
Contributor

coderabbitai bot commented Dec 12, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request encompass various modifications across multiple files in the Ginger project. Key updates include enhancements to error handling, control flow improvements, and the introduction of new properties and methods. Notable changes involve the addition of null checks and better management of UI elements in the ActionEditPage and ValidationDBPage classes, as well as refinements in the handling of external item fields in the ExternalItemFieldBase class. Additionally, several Dockerfile and project file updates reflect dependency management and environment configuration changes.

Changes

File Change Summary
Ginger/Ginger/ALM/ALMItemsFieldsConfigurationPage.xaml.cs Modified error handling and control flow in the Refresh method to check ALM project connection before executing RunWorker(true).
Ginger/Ginger/ALM/Repository/OctaneRepository.cs Added null or empty check for ALMTestSetLevel in ExportBusinessFlowToALM method to prevent null reference exceptions.
Ginger/Ginger/Actions/ActionEditPage.xaml.cs Enhanced UI element handling and data binding; added new methods for managing data sources and output values.
Ginger/Ginger/Actions/ActionEditPages/ActBrowserElementEditPage.xaml.cs Added handling for SetAlertBoxText control action to modify UI visibility and label content.
Ginger/Ginger/Actions/ActionEditPages/ActGenerateFileFromTemplateEditPage.xaml.cs Removed commented-out variable declaration; improved UI element binding and file selection logic.
Ginger/Ginger/Actions/ActionEditPages/ActUIElementLib/UIElementScrollToOptionsPage.xaml.cs Added license comment block; no functional changes.
Ginger/Ginger/Actions/ActionEditPages/ValidationDBPage.xaml.cs Streamlined asynchronous table retrieval by removing nested Task.Run block; improved error handling.
Ginger/Ginger/ApplicationModelsLib/ModelParams Pages/ModelParamsPage.xaml.cs Added null checks and placeholder name conflict checks in UploadToGlobalParam and grdLocalParams_CellEditEnding methods.
Ginger/Ginger/ApplicationModelsLib/POMModels/POMEditPage.xaml.cs Added methods for managing agents and target applications; improved handling of application platform filtering.
Ginger/Ginger/AutomatePageLib/AddActionMenu/WindowExplorer/Common/ControlActionsPage_New.xaml.cs Introduced method for formatting action descriptions; updated logic for setting ElementData.
Ginger/Ginger/Environments/GingerOpsEnvWizardLib/AddGingerOpsEnvPage.xaml.cs Enhanced combo box selection handling and error logging; improved user feedback mechanisms.
Ginger/Ginger/External/Katalon/ImportKatalonObjectRepositoryWizard.cs Added license comment block; modified constructor to include new property affecting navigation behavior.
Ginger/Ginger/External/Katalon/ImportPOMFromObjectRepositoryWizardPage.xaml.cs Added license comment block; updated variable initialization syntax.
Ginger/Ginger/External/Katalon/ImportPOMSummaryWizardPage.xaml.cs Added license header; modified wizard event handling to enable finish button on active event.
Ginger/Ginger/External/Katalon/KatalonConvertedPOMViewModel.cs Added license header; no functional changes.
Ginger/Ginger/External/Katalon/SelectObjectRepositoryFolderWizardPage.xaml.cs Added license header; modified wizard event handling to disable finish button on active event.
Ginger/Ginger/Ginger.csproj Updated package reference for Ginger.ExecuterService.Contracts from 24.3.1 to 24.5.4; removed several files and resources.
Ginger/Ginger/Run/RunSetsExecutionsHistoryPage.xaml.cs Updated execution logger initialization; refined deletion logic for execution results.
Ginger/Ginger/SolutionAutoSaveAndRecover/RecoverPage.xaml.cs Enhanced null safety and error handling in cleanup and file loading methods.
Ginger/Ginger/SolutionWindows/TreeViewItems/EnvironmentsTreeItems/EnvironmentsFolderTreeItem.cs Reorganized context menu item addition; no functional changes.
Ginger/GingerCoreCommon/Actions/Act.cs Updated PrepareItemToBeCopied method for null safety; modified equality comparison methods for clarity.
Ginger/GingerCoreCommon/Actions/ActInputValue.cs Enhanced equality comparison logic for Value property.
Ginger/GingerCoreCommon/GingerCoreCommon.csproj Updated versioning information from 24.5.1.0 to 24.5.0.0.
Ginger/GingerCoreCommon/Repository/ALMLib/ExternalItemFieldBase.cs Added new fields and properties for handling possible value keys and selected value keys.
Ginger/GingerCoreCommon/Repository/BusinessFlowLib/Activity.cs Updated PrepareItemToBeCopied and AreEqual methods for null safety.
Ginger/GingerCoreCommon/Repository/BusinessFlowLib/BusinessFlow.cs Simplified equality checks by removing TargetApplications comparisons.
Ginger/GingerCoreCommon/Repository/SolutionRepository.cs Enhanced file name generation and error logging; added new methods for better item management.
Ginger/GingerCoreCommon/VariablesLib/VariableBase.cs Modified AreEqual method to use specific comparison logic.
Ginger/GingerCoreCommonTest/EqualityTests/ActivityTests.cs Introduced unit tests for Activity class equality logic.
Ginger/GingerCoreCommonTest/EqualityTests/BusinessFlowTests.cs Added unit tests for BusinessFlow class equality logic.
Ginger/GingerCoreCommonTest/GingerCoreCommonTest.csproj Added EqualityTests folder to project structure.
Ginger/GingerCoreNET/ALMLib/Azure/AzureDevOpsCore.cs Enhanced attachment handling with retry logic in AddAttachmentsToDefect.
Ginger/GingerCoreNET/ALMLib/Generic/ALMCore.cs Updated RefreshALMItemFields method to handle PossibleValueKeys.
Ginger/GingerCoreNET/ALMLib/RQM/ExportToRQM.cs Added SelectedValueKey property; refined error handling in export methods.
Ginger/GingerCoreNET/ALMLib/RQM/ImportFromRQM.cs Enhanced handling of external item fields with new properties.
Ginger/GingerCoreNET/ActionsLib/ActScript.cs Updated Execute method for improved handling of script interpreters.
Ginger/GingerCoreNET/Database/DatabaseOperations.cs Added CreateHbaseClient method to streamline HBase client creation.
Ginger/GingerCoreNET/Database/NoSqlBase/GingerHbase.cs Enhanced error handling and streamlined database interaction logic.
Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/ActionHandlers/ActUIElementHandler.cs Added dialog listening functionality in HandleAsync method.
Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/BrowserHelper.cs Improved URL monitoring logic and file path handling.
Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/IBrowserTab.cs Added StartListenDialogsAsync method to interface.
Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Playwright/PlaywrightBrowserTab.cs Enhanced dialog management and network log capturing.
Ginger/GingerCoreNET/Drivers/CoreDrivers/Web/Selenium/SeleniumDriver.cs Improved network log monitoring capabilities and browser action handling.
Ginger/GingerCoreNET/External/JsonExternalItemField.cs Added properties for possible value keys and selected key.
Ginger/GingerCoreNET/External/Katalon/Conversion/KatalonElementEntity.cs Added license comment block; no functional changes.
Ginger/GingerCoreNET/External/Katalon/Conversion/KatalonElementToElementInfoConverter.cs Added license comment block; no functional changes.
Ginger/GingerCoreNET/External/Katalon/Conversion/KatalonObjectRepositoryToPOMConverter.cs Added license header; no functional changes.
Ginger/GingerCoreNET/External/Katalon/Conversion/KatalonWebElementEntity.cs Added license comment block; no functional changes.
Ginger/GingerCoreNET/External/Katalon/Conversion/KatalonWebElementEntityToHTMLElementInfoConverter.cs Added license header; no functional changes.
Ginger/GingerCoreNET/GeneralLib/General.cs Added new method for updating selected value keys and enhanced mapping logic.
Ginger/GingerCoreNET/GingerCoreNET.csproj Updated package reference for Ginger.ExecuterService.Contracts from 24.3.1 to 24.5.4.
Ginger/GingerCoreNET/LiteDBFolder/LiteDbConnector.cs Improved ID handling for report objects in SetCollection method.
Ginger/GingerCoreNET/Reports/Ginger-Web-Client/assets/sass/layout/_dashboard.scss Minor formatting adjustment in styling variables.
Ginger/GingerCoreNET/RunLib/DynamicExecutionLib/DatabaseConfigHelper.cs Added method for decrypting connection strings to enhance security.
Ginger/GingerCoreNETUnitTest/GingerCoreNETUnitTest.csproj Updated package reference for Ginger.ExecuterService.Contracts from 24.3.1 to 24.5.4.
Ginger/GingerCoreNETUnitTest/LinuxTransformationTests/ActScriptTests.cs Enhanced tests for ActScript class with new methods for verifying script interpreter paths.
Ginger/GingerRuntime/Dockerfile Updated installation logic and environment configuration for the GingerRuntime application.
Ginger/GingerRuntime/GingerRuntime.csproj Updated package reference for Ginger.ExecuterService.Contracts from 24.3.1 to 24.5.4.

Poem

In the garden of code, where rabbits play,
Changes bloom bright, in a whimsical way.
With checks for the nulls and logs that delight,
Our Ginger grows stronger, reaching new height.
So hop with joy, let the changes be known,
For in every update, our magic has grown! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Maheshkale447 Maheshkale447 merged commit 1843b14 into master Dec 12, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants