deps: upgrade trace_engine to 0.0.38

cli/test/smokehouse/test-definitions/dobetterweb.js

@@ -272,22 +272,22 @@ const expectations = {
         details: {
           items: [
             {
-              url: 'http://localhost:10200/dobetterweb/dbw_tester.css?delay=100',
+              url: 'http://localhost:10200/dobetterweb/fcp-delayer.js?delay=5000',
             },
             {
-              url: 'http://localhost:10200/dobetterweb/unknown404.css?delay=200',
+              url: 'http://localhost:10200/dobetterweb/dbw_tester.css?delay=3000&capped',
             },
             {
               url: 'http://localhost:10200/dobetterweb/dbw_tester.css?delay=2200',
             },
             {
-              url: 'http://localhost:10200/dobetterweb/dbw_tester.css?delay=3000&capped',
+              url: 'http://localhost:10200/dobetterweb/dbw_tester.js',
             },
             {
-              url: 'http://localhost:10200/dobetterweb/dbw_tester.js',
+              url: 'http://localhost:10200/dobetterweb/unknown404.css?delay=200',
             },
             {
-              url: 'http://localhost:10200/dobetterweb/fcp-delayer.js?delay=5000',
+              url: 'http://localhost:10200/dobetterweb/dbw_tester.css?delay=100',
             },
           ],
         },

core/audits/byte-efficiency/render-blocking-resources.js

@@ -130,7 +130,7 @@ class RenderBlockingResources extends Audit {
     const wastedCssBytes = await RenderBlockingResources.computeWastedCSSBytes(artifacts, context);
     const navInsights = await NavigationInsights.request(trace, context);
 
-    const renderBlocking = navInsights.RenderBlocking;
+    const renderBlocking = navInsights.model.RenderBlocking;
     if (renderBlocking instanceof Error) throw renderBlocking;
 
     /** @type {LH.Audit.Context['settings']} */

core/computed/metrics/cumulative-layout-shift.js

@@ -160,13 +160,13 @@ class CumulativeLayoutShift {
         Screenshots: TraceEngine.TraceHandlers.Screenshots,
       });
       // eslint-disable-next-line max-len
-      await processor.parse(/** @type {import('@paulirish/trace_engine').Types.TraceEvents.TraceEventData[]} */ (
+      await processor.parse(/** @type {import('@paulirish/trace_engine').Types.Events.Event[]} */ (
         events
-      ));
-      if (!processor.traceParsedData) {
+      ), {});
+      if (!processor.parsedTrace) {
         throw new Error('null trace engine result');
       }
-      return processor.traceParsedData.LayoutShifts.sessionMaxScore;
+      return processor.parsedTrace.LayoutShifts.sessionMaxScore;
     };
     const cumulativeLayoutShift = await run(allFrameShiftEvents.map(e => e.event));
     const cumulativeLayoutShiftMainFrame = await run(mainFrameShiftEvents.map(e => e.event));

core/computed/metrics/lantern-metric.js

@@ -38,8 +38,10 @@ async function getComputationDataParamsFromTrace(data, context) {
 
   const graph = await PageDependencyGraph.request({...data, fromTrace: true}, context);
   const traceEngineResult = await TraceEngineResult.request(data, context);
-  const processedNavigation =
-    Lantern.TraceEngineComputationData.createProcessedNavigation(traceEngineResult.data);
+  const frameId = traceEngineResult.data.Meta.mainFrameId;
+  const navigationId = traceEngineResult.data.Meta.mainFrameNavigations[0].args.data.navigationId;
+  const processedNavigation = Lantern.TraceEngineComputationData.createProcessedNavigation(
+    traceEngineResult.data, frameId, navigationId);
   const simulator = data.simulator || (await LoadSimulator.request(data, context));
 
   return {simulator, graph, processedNavigation};

core/computed/network-analysis.js

@@ -16,7 +16,11 @@ class NetworkAnalysis {
    */
   static async compute_(devtoolsLog, context) {
     const records = await NetworkRecords.request(devtoolsLog, context);
-    return Lantern.Core.NetworkAnalyzer.analyze(records);
+    const analyis = Lantern.Core.NetworkAnalyzer.analyze(records);
+    if (!analyis) {
+      throw new Error('Could not compute network analysis');
+    }
+    return analyis;
   }
 }
 

core/computed/trace-engine-result.js

@@ -30,12 +30,12 @@ class TraceEngineResult {
     const processor = new TraceEngine.TraceProcessor(traceHandlers);
 
     // eslint-disable-next-line max-len
-    await processor.parse(/** @type {import('@paulirish/trace_engine').Types.TraceEvents.TraceEventData[]} */ (
+    await processor.parse(/** @type {import('@paulirish/trace_engine').Types.Events.Event[]} */ (
       traceEvents
-    ));
-    if (!processor.traceParsedData) throw new Error('No data');
+    ), {});
+    if (!processor.parsedTrace) throw new Error('No data');
     if (!processor.insights) throw new Error('No insights');
-    return {data: processor.traceParsedData, insights: processor.insights};
+    return {data: processor.parsedTrace, insights: processor.insights};
   }
 
   /**

core/lib/trace-engine.js

@@ -2,7 +2,7 @@ import * as TraceEngine from '@paulirish/trace_engine';
 
 import {polyfillDOMRect} from './polyfill-dom-rect.js';
 
-/** @typedef {import('@paulirish/trace_engine').Types.TraceEvents.SyntheticLayoutShift} SyntheticLayoutShift */
+/** @typedef {import('@paulirish/trace_engine').Types.Events.SyntheticLayoutShift} SyntheticLayoutShift */
 /** @typedef {SyntheticLayoutShift & {args: {data: NonNullable<SyntheticLayoutShift['args']['data']>}}} SaneSyntheticLayoutShift */
 
 polyfillDOMRect();

core/test/audits/dobetterweb/dom-size-test.js

@@ -18,7 +18,7 @@ describe('DOMSize audit', () => {
 
   beforeEach(() => {
     const mainDocumentUrl = 'https://example.com/';
-    const networkRecords = [{url: mainDocumentUrl, priority: 'High'}];
+    const networkRecords = [{url: mainDocumentUrl, priority: 'High', transferSize: 1000}];
     const trace = createTestTrace({
       largestContentfulPaint: 15,
       topLevelTasks: [

core/test/audits/dobetterweb/uses-http2-test.js

@@ -43,31 +43,37 @@ describe('Resources are fetched over http/2', () => {
   it('should pass when resources are requested via http/2', async () => {
     const networkRecords = [{
       url: 'https://www.example.com/',
+      transferSize: 1000,
       priority: 'High',
       protocol: 'h2',
     },
     {
       url: 'https://www.example.com/2',
+      transferSize: 1000,
       priority: 'High',
       protocol: 'h2',
     },
     {
       url: 'https://www.example.com/3',
+      transferSize: 1000,
       priority: 'High',
       protocol: 'h2',
     },
     {
       url: 'https://www.example.com/4',
+      transferSize: 1000,
       priority: 'High',
       protocol: 'h2',
     },
     {
       url: 'https://www.example.com/5',
+      transferSize: 1000,
       priority: 'High',
       protocol: 'h2',
     },
     {
       url: 'https://www.example.com/6',
+      transferSize: 1000,
       priority: 'High',
       protocol: 'h2',
     },
@@ -267,36 +273,43 @@ describe('Resources are fetched over http/2', () => {
     const networkRecords = [
       {
         url: 'https://www.twitter.com/',
+        transferSize: 1000,
         priority: 'High',
         protocol: 'HTTP/1.1',
       },
       {
         url: 'https://www.twitter.com/2',
+        transferSize: 1000,
         priority: 'High',
         protocol: 'HTTP/1.1',
       },
       {
         url: 'https://www.twitter.com/3',
+        transferSize: 1000,
         priority: 'High',
         protocol: 'HTTP/1.1',
       },
       {
         url: 'https://www.twitter.com/4',
+        transferSize: 1000,
         priority: 'High',
         protocol: 'HTTP/1.1',
       },
       {
         url: 'https://www.twitter.com/5',
+        transferSize: 1000,
         priority: 'High',
         protocol: 'HTTP/1.1',
       },
       {
         url: 'https://www.twitter.com/embed/foo',
+        transferSize: 1000,
         priority: 'High',
         protocol: 'HTTP/1.1',
       },
       {
         url: 'https://www.facebook.com/embed',
+        transferSize: 1000,
         protocol: 'HTTP/1.1',
         priority: 'High',
       },

core/test/audits/long-tasks-test.js

@@ -152,6 +152,7 @@ describe('Long tasks audit', () => {
       url: TASK_URL,
       priority: 'High',
       timing: {connectEnd: 50, connectStart: 0.01, sslStart: 25, sslEnd: 40},
+      transferSize: 1000,
     }];
 
     const artifacts = {

core/test/audits/redirects-test.js

@@ -34,6 +34,7 @@ const FAILING_THREE_REDIRECTS = [{
   priority: 'VeryHigh',
   url: 'https://m.example.com/final',
   timing: {receiveHeadersEnd: 19},
+  transferSize: 1000,
 }];
 
 const FAILING_TWO_REDIRECTS = [{
@@ -54,6 +55,7 @@ const FAILING_TWO_REDIRECTS = [{
   priority: 'VeryHigh',
   url: 'https://www.lisairish.com/',
   timing: {receiveHeadersEnd: 448},
+  transferSize: 1000,
 }];
 
 const SUCCESS_ONE_REDIRECT = [{
@@ -68,6 +70,7 @@ const SUCCESS_ONE_REDIRECT = [{
   priority: 'VeryHigh',
   url: 'https://www.lisairish.com/',
   timing: {receiveHeadersEnd: 139},
+  transferSize: 1000,
 }];
 
 const SUCCESS_NOREDIRECT = [{
@@ -76,6 +79,7 @@ const SUCCESS_NOREDIRECT = [{
   priority: 'VeryHigh',
   url: 'https://www.google.com/',
   timing: {receiveHeadersEnd: 140},
+  transferSize: 1000,
 }];
 
 const FAILING_CLIENTSIDE = [
@@ -92,13 +96,15 @@ const FAILING_CLIENTSIDE = [
     priority: 'VeryHigh',
     url: 'https://lisairish.com/',
     timing: {receiveHeadersEnd: 447},
+    transferSize: 1000,
   },
   {
     requestId: '2',
     networkRequestTime: 447_000,
     priority: 'VeryHigh',
     url: 'https://www.lisairish.com/',
     timing: {receiveHeadersEnd: 448},
+    transferSize: 1000,
   },
 ];
 
@@ -108,20 +114,23 @@ const FAILING_SELF_REDIRECT = [{
   priority: 'VeryHigh',
   networkRequestTime: 0,
   responseHeadersEndTime: 500,
+  transferSize: 1000,
 },
 {
   requestId: '2',
   url: 'https://redirect.test/',
   priority: 'VeryHigh',
   networkRequestTime: 1000,
   responseHeadersEndTime: 1500,
+  transferSize: 1000,
 },
 {
   requestId: '3',
   url: 'https://redirect.test/',
   priority: 'VeryHigh',
   networkRequestTime: 3000,
   responseHeadersEndTime: 3500,
+  transferSize: 1000,
 }];
 
 describe('Performance: Redirects audit', () => {

core/test/audits/uses-rel-preconnect-test.js

@@ -18,6 +18,10 @@ const mainResource = {
 };
 
 function buildArtifacts(networkRecords, fcpTs) {
+  for (const record of networkRecords) {
+    record.transferSize = record.transferSize ?? 1000;
+  }
+
   const trace = createTestTrace({
     timeOrigin: 0,
     largestContentfulPaint: 5000,

core/test/audits/uses-rel-preload-test.js

@@ -51,6 +51,7 @@ describe('Performance: uses-rel-preload audit', () => {
       {
         requestId: '2',
         networkRequestTime: 10_000,
+        transferSize: 1000,
         isLinkPreload: false,
         url: secondRecordUrl,
         timing: defaultMainResource.timing,
@@ -63,6 +64,7 @@ describe('Performance: uses-rel-preload audit', () => {
         // Normally this request would be flagged for preloading.
         requestId: '3',
         networkRequestTime: 20_000,
+        transferSize: 1000,
         isLinkPreload: false,
         url: 'http://www.example.com/a-different-script.js',
         timing: defaultMainResource.timing,
@@ -100,6 +102,7 @@ describe('Performance: uses-rel-preload audit', () => {
         isLinkPreload: false,
         networkRequestTime: 500,
         networkEndTime: 1000,
+        transferSize: 1000,
         timing: {receiveHeadersEnd: 500},
         url: mainDocumentNodeUrl,
       },
@@ -110,6 +113,7 @@ describe('Performance: uses-rel-preload audit', () => {
         isLinkPreload: false,
         networkRequestTime: 1000,
         networkEndTime: 2000,
+        transferSize: 1000,
         timing: {receiveHeadersEnd: 1000},
         url: scriptNodeUrl,
         initiator: {type: 'parser', url: mainDocumentNodeUrl},
@@ -121,6 +125,7 @@ describe('Performance: uses-rel-preload audit', () => {
         isLinkPreload: false,
         networkRequestTime: 2000,
         networkEndTime: 3_250,
+        transferSize: 1000,
         timing: {receiveHeadersEnd: 1250},
         url: scriptAddedNodeUrl,
         initiator: {type: 'script', url: scriptNodeUrl},
@@ -132,6 +137,7 @@ describe('Performance: uses-rel-preload audit', () => {
         isLinkPreload: false,
         networkRequestTime: 2000,
         networkEndTime: 3000,
+        transferSize: 1000,
         timing: {receiveHeadersEnd: 1000},
         url: scriptSubNodeUrl,
         initiator: {type: 'script', url: scriptNodeUrl},
@@ -143,6 +149,7 @@ describe('Performance: uses-rel-preload audit', () => {
         isLinkPreload: false,
         networkRequestTime: 2000,
         networkEndTime: 3_500,
+        transferSize: 1000,
         timing: {receiveHeadersEnd: 1500},
         url: scriptOtherNodeUrl,
         initiator: {type: 'script', url: scriptNodeUrl},
@@ -170,7 +177,7 @@ describe('Performance: uses-rel-preload audit', () => {
     const artifacts = mockArtifacts(networkRecords, defaultMainResourceUrl);
     const context = {settings: {}, computedCache: new Map()};
     return UsesRelPreload.audit(artifacts, context).then(output => {
-      assert.equal(output.details.overallSavingsMs, 314);
+      assert.equal(output.details.overallSavingsMs, 303);
       assert.equal(output.details.items.length, 1);
     });
   });