Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(target-manager): ignore target if type is unknown #16221

Merged
merged 6 commits into from
Nov 5, 2024
Merged

core(target-manager): ignore target if type is unknown #16221

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d36435
core(target-manager): ignore targets that don't implement `Target.get…
adamraine Oct 10, 2024
9016a51
Merge branch 'main' into ignore-bad-targets
adamraine Nov 4, 2024
28e6e7f
Merge branch 'main' into ignore-bad-targets
adamraine Nov 4, 2024
7986439
Merge branch 'ignore-bad-targets' of github.com:GoogleChrome/lighthou…
adamraine Nov 4, 2024
051385f
check
adamraine Nov 4, 2024
9229e50
test
adamraine Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/gather/driver/target-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,10 @@
// Sometimes targets can be closed before we even have a chance to listen to their network activity.
if (/Target closed/.test(err.message)) return;

// `Target.getTargetInfo` is not implemented for certain target types.
// Lighthouse isn't interested in these targets anyway so we can just ignore them.
if (/'Target.getTargetInfo' wasn't found/.test(err)) return;

Check warning on line 176 in core/gather/driver/target-manager.js

View check run for this annotation

Codecov / codecov/patch

core/gather/driver/target-manager.js#L173-L176 

Added lines #L173 - L176 were not covered by tests
// Worker targets can be a bit fickle and we only enable them for diagnostic purposes.
// We shouldn't throw a fatal error if there were issues attaching to them.
if (targetType === 'worker') {
Expand Down
Loading