Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients(lr): adjust CPU throttling based on benchmark #16256

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

adamraine
Copy link
Member

@adamraine adamraine commented Nov 19, 2024

Further analysis indicates that 1.2x might be better than 1.5x in PSI. 1.2x is recommended by https://lighthouse-cpu-throttling-calculator.vercel.app/ but 1.5x was just the high end of the reported range.

@adamraine adamraine requested a review from a team as a code owner November 19, 2024 01:21
@adamraine adamraine requested review from connorjclark and removed request for a team November 19, 2024 01:21
@connorjclark
Copy link
Collaborator

connorjclark commented Nov 27, 2024

I mentioned elsewhere, but that web app is using a different LHBIDX target than our current moto g4 power 2022 device. it uses 150 as the target score, but if we wrote that app today we would use ~264

Does this modify your suggested throttling rate at all?

@adamraine
Copy link
Member Author

Does this modify your suggested throttling rate at all?

I found the code for the CPU throttling estimator here. Lazily replacing 150 with 264 gives us a multiplier of ~1.05 or ~1.1 if we round it.

That being said, the confidence range of 1.2 contains 1.05 and vice versa so I think it's splitting hairs.

@adamraine adamraine merged commit dfc2a4b into main Dec 2, 2024
27 checks passed
@adamraine adamraine deleted the lr-cpu-benchmark-2 branch December 2, 2024 17:57
@jmwebservices
Copy link

jmwebservices commented Dec 7, 2024

As a performance-focused developer, my PSI mobile performance scores would inconsistently dip into the high 80s due to blocking from third-party scripts. Interestingly, GTM was the only third-party script used. Thankfully, it seems this issue has been resolved, and now my mobile performance scores consistently hit 99-100!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants