new_audit: use a strong HSTS policy #16257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update:sample-json.
… into hsts-audit
adamraine
changed the title
adamraine
reviewed
Nov 19, 2024
adamraine
reviewed
Nov 19, 2024
… Also hide the result from the report UI.
sebastian9er
added a commit
to sebastian9er/lighthouse
that referenced
this pull request
Nov 21, 2024
adamraine
reviewed
Nov 21, 2024
adamraine
reviewed
Nov 21, 2024
adamraine
reviewed
Nov 21, 2024
…il docs are published, some text phrasings and the smoke test assertions.
adamraine
approved these changes
Nov 22, 2024
Co-authored-by: Adam Raine <[email protected]>
Co-authored-by: Adam Raine <[email protected]>
Co-authored-by: Adam Raine <[email protected]>
Co-authored-by: Adam Raine <[email protected]>
Co-authored-by: Adam Raine <[email protected]>
|
Thanks Adam! Is there anything left to do from my side here? |
Don't think so! |
|
Thanks for including the proper Link, Adam! I didn't know when my doc got pushed to https://developer.chrome.com/docs/lighthouse/best-practices/has-hsts. But that was actually quite fast :D |
…use/best-practices/has-hsts. Updating json files to account for the changes.
|
Ran update:sample-json to account for the string change in the last commit. |
sebastian9er
added a commit
to sebastian9er/lighthouse
that referenced
this pull request
Dec 4, 2024
sebastian9er
added a commit
to sebastian9er/lighthouse
that referenced
this pull request
Dec 4, 2024
sebastian9er
added a commit
to sebastian9er/lighthouse
that referenced
this pull request
Dec 4, 2024
sebastian9er
added a commit
to sebastian9er/lighthouse
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a new audit to Ligththouse, which detects deviations from an optimal HSTS header deployment.
Part of a larger change to introduce more similar header deployments.
Link to documentation is pending internal discussions (@adamraine FYI, either of us can update the Link here once we have the blog post done).