i18n: inject strings from trace engine npm package #16272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
reviewed
Dec 3, 2024
|
Remaining failures seem unrelated, happening on main. |
But they're added to the en-US locale? Won't they get auto-uploaded on our next i18n push? |
|
No, because we export |
adamraine
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a step to the end our our string collection process to inject strings found under
node_modules/@paulirish/trace_engine/locales(newly published).These strings will not be sent to TC: so we'll be able to use the exact same strings as CDT.
TraceEngineResulthandles doing the actual localization. When we start making insight audits, they can simply use the model's title/description as-is.