core(prioritize-lcp-image): report negative savings as 0 #16276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsilverstein
requested review from
connorjclark
and removed request for
a team
adamsilverstein
commented
Dec 5, 2024
| @@ -216,7 +216,7 @@ class PrioritizeLcpImage extends Audit { | |||
| } | |||
|
|
|||
| const wastedMs = lcpTimingsBefore.endTime - | |||
| Math.max(lcpTimingsAfter.endTime, maxDependencyEndTime); | |||
| Math.max(lcpTimingsAfter.endTime, maxDependencyEndTime > lcpTimingsBefore.endTime ? lcpTimingsBefore.endTime : maxDependencyEndTime); | |||
There was a problem hiding this comment.
Another option would be to throw an error for this case, what do you think? Do we need to dig deeper into why maxDependencyEndTime is greater than lcpTimingsAfter.endTime?
There was a problem hiding this comment.
Let's not throw an error, but I don't think this PR should close #16261
Also could we do something like wastedMs = Math.max(wastedMs, 0) on the line below this. I think that would make this easier to read.
adamsilverstein
changed the title
adamraine
changed the title
|
I don't like this sort of fix because it covers up this and future problems. I suggest not doing this, but defer to @adamraine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #16261.