Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove auto generated docs line with current date #732

Merged

Conversation

froblesmartin
Copy link
Contributor

Right now the CI will fail with any new PR due to the change in the date.

To avoid it, I propose to remove that generated line with the feature flag of the generator.

@jackwotherspoon
Copy link
Contributor

Can confirm this worked for the Cloud SQL builds: https://github.com/GoogleCloudPlatform/cloud-sql-proxy/actions/runs/12182514848/job/33981712140?pr=2342

nit: @froblesmartin I think this PR should probably be a docs: or ci: prefix, we normally reserve fix: for a bug fix that touched production code. 😄

Thanks again! 👍

@froblesmartin froblesmartin changed the title fix: remove auto generated docs line with current date ci: remove auto generated docs line with current date Dec 5, 2024
@froblesmartin
Copy link
Contributor Author

Can confirm this worked for the Cloud SQL builds: https://github.com/GoogleCloudPlatform/cloud-sql-proxy/actions/runs/12182514848/job/33981712140?pr=2342

nit: @froblesmartin I think this PR should probably be a docs: or ci: prefix, we normally reserve fix: for a bug fix that touched production code. 😄

Thanks again! 👍

You are welcome! 😄 I have changed the PR title. Will you squash or should I amend the commit too? 🤔

@jackwotherspoon
Copy link
Contributor

You are welcome! 😄 I have changed the PR title. Will you squash or should I amend the commit too? 🤔

We will squash so no need to amend 😄

Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@enocom enocom enabled auto-merge (squash) December 5, 2024 16:04
@enocom enocom disabled auto-merge December 5, 2024 16:04
@enocom enocom enabled auto-merge (squash) December 5, 2024 16:04
@enocom enocom merged commit 5c1a829 into GoogleCloudPlatform:main Dec 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants