Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: configure webhook to ignore kube-system #499

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: configure webhook to ignore kube-system #499

merged 1 commit into from
Dec 11, 2023

Conversation

enocom
Copy link
Member

@enocom enocom commented Dec 8, 2023

Fixes #461.

@enocom enocom requested a review from a team as a code owner December 8, 2023 15:21
@enocom
Copy link
Member Author

enocom commented Dec 8, 2023 •
edited
Loading

Haven't manually tested that this works, but putting up a PR for comments until then.

Confirmed this works to remove the warning message.

@enocom enocom force-pushed the ignore-kube-system branch from 5c5c2a7 to 8d0ae3d Compare December 8, 2023 16:43
@enocom enocom force-pushed the ignore-kube-system branch from 8d0ae3d to a433af2 Compare December 9, 2023 05:24
hessjcg
hessjcg approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@hessjcg hessjcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enocom enocom added the tests: run Run all the tests for this PR label Dec 11, 2023
@github-actions github-actions bot removed the tests: run Run all the tests for this PR label Dec 11, 2023
@enocom enocom merged commit 291de15 into main Dec 11, 2023
12 checks passed
@enocom enocom deleted the ignore-kube-system branch December 11, 2023 17:24
@release-please release-please bot mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hessjcg hessjcg hessjcg approved these changes

Assignees

@hessjcg hessjcg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mutatingWebhook is being flagged as unsafe
2 participants
@enocom @hessjcg