Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal responsive improvements #14087

Merged
merged 8 commits into from
Jul 8, 2022

Conversation

scootyboots
Copy link
Contributor

This is to improve the responsive behavior of the profile modal on smaller/medium size screens. Because the profile component is the same for the profile page and modal, the profile page will also be slightly affected.

Fixes #14070 #13944

Changes

  • changes only to css and removing a few html elements and unnecessary classes
  • mostly accomplished though adding some new media queries

UUID: UUID: 80b23d68-9bd6-4962-8146-636b20aece8c

@SabreCat
Copy link
Member

This is a huge improvement, thank you @scootyboots! I only see one thing worth fixing before merge, on a run through: at minimum width when viewing one's own profile in the modal, the username could stand to have a little bit more margin up top so it doesn't fall underneath the class badge.

image

@SabreCat SabreCat marked this pull request as draft June 24, 2022 20:56
@scootyboots
Copy link
Contributor Author

Thanks @SabreCat, no problem!

I've added some more margin so the class badge doesn't overlap with the user name. I've also added some more styling for the stats allocation section to handle middle-width screen better.

@SabreCat SabreCat marked this pull request as ready for review July 8, 2022 20:43
@SabreCat SabreCat merged commit 8ecb0f4 into HabitRPG:develop Jul 8, 2022
@SabreCat
Copy link
Member

SabreCat commented Jul 8, 2022

Thanks for this, @scootyboots, and welcome to the ranks of the Blacksmiths at tier 1! This will go into our staging environment for a few days, and you should see it live on the main site late next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile Modal displays poorly at smaller screen sizes
2 participants