feat(button): adds text container props to enable styling Text/string #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing subcomponents
|
App is ready for review, you can see it here. |
aVileBroker
reviewed
Aug 24, 2021
| iconPrefix?: string | JSX.Element; | ||
| iconSuffix?: string | JSX.Element; | ||
| isLoading?: boolean; | ||
| isProcessing?: boolean; | ||
| children?: string; | ||
| children?: ReactNode[]; |
There was a problem hiding this comment.
I don't think this needs to be an array of ReactNodes - but I could be wrong.
There was a problem hiding this comment.
Or is this the only way we can do the textcontainer stuff?
|
Made this PR a draft for now while we discuss potentially updating the architectural design to use a HOC to wrap each component and pre-process the children |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows user to provide a text container subcomponent for the Button component