Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figma@beta: migrate from homebrew/cask-versions #172344

Merged
merged 1 commit into from
Apr 27, 2024
Merged

figma@beta: migrate from homebrew/cask-versions #172344

merged 1 commit into from
Apr 27, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Apr 27, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Experimenting Homebrew/homebrew-cask-versions#19665

Simpler one as no conflicts to modify

Copy link
Member

@razvanazamfirei razvanazamfirei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving both this and Homebrew/homebrew-cask-versions#20185. Feel free to merge whenever ready.

@cho-m cho-m marked this pull request as ready for review April 27, 2024 16:20
@reitermarkus
Copy link
Member

reitermarkus commented Apr 27, 2024

I'd say let's merge and then check if the following works:

  • With taps reset to old commits:

    • brew install homebrew/cask-versions/figma-beta
    • brew update (should migrate to the new name)
  • With taps reset to old commits:

    • brew install homebrew/cask-versions/figma-beta
    • brew update-reset
    • brew migrate figma-beta (should migrate to the new name)
  • With and without API:

    • brew install figma-beta (should show migration warning)
    • brew install homebrew/cask-versions/figma-beta (should show migration warning)
    • brew install homebrew/cask-versions/figma@beta (should fail)
    • brew install figma@beta (should not show migration warning)
    • brew install homebrew/cask/figma@beta (should not show migration warning)
    • brew install homebrew/cask/figma-beta (should fail)

@cho-m cho-m merged commit 3c4d3b1 into master Apr 27, 2024
12 checks passed
@cho-m cho-m deleted the figma-beta branch April 27, 2024 18:39
@cho-m
Copy link
Member Author

cho-m commented Apr 27, 2024

I had figma-beta installed for testing. After merge, via repo tap (non-API):

brew update
==> Updating Homebrew...
==> Updated Homebrew from 0bb104d6e1 to 5e027bffd6.
Updated 3 taps (homebrew/cask-versions, homebrew/core and homebrew/cask).
==> New Casks
figma@beta
==> Deleted Installed Casks
figma-beta ✘
==> Migrating cask figma-beta to figma@beta

EDIT: There will a minor downtime in Cask availability via API since this is moving from tap to API.

@cho-m
Copy link
Member Author

cho-m commented Apr 27, 2024

  • With and without API:

    ...

    • brew install homebrew/cask-versions/figma-beta (should show migration warning)

This doesn't show a migration warning. Probably not a blocker as essential behavior seems to work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants