rpds-py 0.22.3 (new formula) #201147
Open
rpds-py 0.22.3 (new formula) #201147
+78
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
automerge-skip
marcusmueller
force-pushed
the
rpds-py
branch
from
f077c1f to
37af725
Compare
For GNU Radio, we need jsonschema, which in turn depends on rpds-py, which in turn depends on Rust. It seemed desirable to move that dependency (since it's generally useful and doesn't need to be rebuilt for every GNU Radio build) into its own formula. See GH Homebrew#201049. This supersedes Homebrew#178716. Unlike that, it uses the existing maturin formula instead of doing a pypi-based source build. Signed-off-by: Marcus Müller <[email protected]>
marcusmueller
force-pushed
the
rpds-py
branch
from
37af725 to
20bb67d
Compare
SMillerDev
reviewed
Dec 14, 2024
|
|
||
| depends_on "maturin" => :build | ||
| depends_on "[email protected]" => [:build, :test] | ||
| depends_on "[email protected]" => [:build, :test] |
There was a problem hiding this comment.
I was under the impression that this was the expected combination of python versions, from other formulae.
There was a problem hiding this comment.
@SMillerDev added the most recent python version
| @@ -740,6 +740,9 @@ | |||
| "extra_packages": ["robotframework-archivelibrary", "robotframework-selenium2library", "robotframework-sshlibrary"], | |||
| "exclude_packages": ["certifi", "cryptography"] | |||
| }, | |||
| "rpds-py": { | |||
| "extra_packages": ["setuptools-rust"] | |||
There was a problem hiding this comment.
because that's what was in #178716, and because it is needed by the build process of rpds-py.
There was a problem hiding this comment.
(I think this is the kind of indirect dependency @cho-m explained to me here)
as recommended in https://github.com/Homebrew/homebrew-core/pull/201147\#discussion_r1885061268 Signed-off-by: Marcus Müller <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For GNU Radio, we need jsonschema, which in turn depends on rpds-py,
which in turn depends on Rust. It seemed desirable to move that
dependency (since it's generally useful and doesn't need to be rebuilt
for every GNU Radio build) into its own formula. See GH #201049.
This supersedes #178716. Unlike that, it uses the existing maturin
formula instead of doing a pypi-based source build.
Signed-off-by: Marcus Müller [email protected]
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?brew auditfails with(I have far too many privileges on repos for me to just grant
repoprivileges to some tool whose code I haven't read; so I'm afraid adding a random API token to audit a formula won't happen.)