wcstools 3.9.7 (new formula) #202219
Open
wcstools 3.9.7 (new formula) #202219
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new formula
github-actions
bot
added
the
autosquash
github-actions
bot
removed
the
autosquash
carlocab
reviewed
Dec 23, 2024
github-actions
bot
added
autosquash
github-actions
bot
added
automerge-skip
nandahkrishna
force-pushed
the
wcstools-3.9.7
branch
from
ac6b215 to
6004006
Compare
github-actions
bot
removed
the
automerge-skip
nandahkrishna
force-pushed
the
wcstools-3.9.7
branch
from
6004006 to
a6bbcc1
Compare
carlocab
reviewed
Dec 27, 2024
Formula/w/wcstools.rb
Outdated
Comment on lines
14
to
15
| include.install Dir["libwcs/*.h"] | ||
| man1.install Dir["man/man1/*.1"] |
There was a problem hiding this comment.
Suggested change
| include.install Dir["libwcs/*.h"] | |
| man1.install Dir["man/man1/*.1"] | |
| (include/"libwcs").install buildpath.glob("libwcs/*.h") | |
| man1.install buildpath.glob("man/man1/*.1") |
Do we really need to install these headers? We're not installing the library, so they don't seem very useful.
There was a problem hiding this comment.
No, There is no need for these headers as it may lead to conflict with wcslib. if the version of wcslib is difference
wcstools should worked without the headers.
github-actions
bot
added
the
autosquash
carlocab
reviewed
Dec 27, 2024
Co-authored-by: Nanda H Krishna <[email protected]> Update Formula/w/wcstools.rb Co-authored-by: Carlo Cabrera <[email protected]> remove wcslib header There is no need Co-authored-by: Carlo Cabrera <[email protected]> Update Formula/w/wcstools.rb Co-authored-by: Carlo Cabrera <[email protected]>
github-actions
bot
removed
the
autosquash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?