Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how
--all
behaves. When stopping all services, it filters out the services that are already stopped, and vice versa when starting all services.My motivation for this change is that I have
dnscrypt-proxy
installed which causesbrew services stop --all
to no longer work properly and stop halfway through.With my changes it works the way I want it to:
You'll no longer see
Warning: Service `X` is not started.
warnings when using--all
, which cleans up the output a lot.If you have root services then
brew services start --all
no longer tries to start them. Perhaps a new switch should be included to allow this to be controlled, e.g.--include-root
? In my opinion the default should exclude root services since I think it is the exception rather than the rule where you want to include them, right?The tests are still passing. Please let me know if you want me to make any changes. If you want me to add to the tests then please let me know. I don't want to spend time on tests unless the changes are desirable.
Thanks!