install.sh: prefer placing shellenv command in rcfile rather than shell profile on Linux
#809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
commented
Sep 27, 2023
| ;; | ||
| *) | ||
| shell_profile="${HOME}/.profile" | ||
| shell_rcfile="${ENV:-"${HOME}/.profile"}" |
There was a problem hiding this comment.
Reference for the ENV environment variable:
Stack Overflow: Is there an alternative for .bashrc for /bin/sh?
2 tasks
MikeMcQuaid
previously approved these changes
Sep 27, 2023
|
Thanks again @XuehaiPan! |
7 tasks
XuehaiPan
changed the title
shellenv command in rcfile rather than shell profileshellenv command in rcfile rather than shell profile on Linux
colindean
approved these changes
Oct 4, 2023
MikeMcQuaid
approved these changes
Oct 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompt user to add
shellenvcommand in theirrcfilerather than the shell profile. The profile is only sourced by the login shell, while thercfileis always sourced in an interactive session.Resolves #808.