Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Optimus.changelog.md #329

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update Optimus.changelog.md #329

wants to merge 7 commits into from

Conversation

ekiernan
Copy link
Contributor

Purpose

Review updated Optimus Changelog

Changes

  • No changes.

Review Instructions

  • No instructions.

@ekiernan ekiernan requested a review from barkasn April 24, 2020 13:24
Copy link
Contributor

@barkasn barkasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2020-04-24 (Date of Last Commit)

* Added a new counting_mode parameter to Optimus workflow which enables processing of single-nuclei datasets

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the standard to add a blank line between each bulleted item in the changelog? I don't think we're doing that in dsde-pipelines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never talked about when making the style guide- I will have to update the guide. I changed the changelog here to be single space so that it matches dsde-pipelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants