This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LEAP-148: Fix MagicWand in MIG scenario with image preloading #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d2330f7)
Gondragos
changed the title
Gondragos
force-pushed
the
fb-lsdv-4864/noasync-magicwand-mig
branch
from
17f88a1 to
d25814e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1685 +/- ##
=======================================
Coverage 68.70% 68.70%
=======================================
Files 443 443
Lines 28734 28736 +2
Branches 7641 7645 +4
=======================================
+ Hits 19742 19744 +2
Misses 7748 7748
Partials 1244 1244 ☔ View full report in Codecov by Sentry. |
juliosgarbi
approved these changes
Jan 30, 2024
hlomzik
approved these changes
Jan 31, 2024
tests/functional/package.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| "cvg:summary": "nyc report --temp-dir=.nyc_output --reporter=text-summary --cwd=. --exclude-after-remap false" | |||
| }, | |||
| "dependencies": { | |||
| "@heartexlabs/ls-test": "heartexlabs/ls-frontend-test#9ff949fc19abaf124477dfd41c6f230b00665ab3" | |||
| "@heartexlabs/ls-test": "heartexlabs/ls-frontend-test#2c9410fb930c7d920474fe6e624efee6261cec0c" | |||
There was a problem hiding this comment.
don't forget to switch back to master version after merging changes in the testing library
nick-skriabin
approved these changes
Jan 31, 2024
MasherJames
pushed a commit
to HelloPareto/label-studio-frontend
that referenced
this pull request
Feb 29, 2024
…umanSignal#1685) When both MIG and image preloading are enabled, there was no canvas overlay for the Magic Wand which caused the Magic Wand to fail. * fix: LSDV-4864: Fix MagicWand in MIG scenario with image preloading (cherry picked from commit d2330f7) * Update ls-test dependency * Fix tests --------- Co-authored-by: Nick Skriabin <[email protected]> Co-authored-by: hlomzik <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When both MIG and image preloading are enabled, there was no canvas overlay for the Magic Wand which caused the Magic Wand to fail.
PR fulfills these requirements
What feature flags were used to cover this change?
Not really covered but affected by:
fflag_feat_front_lsdv_4583_6_images_preloading_shortfflag_feat_front_dev_4081_magic_wand_toolWhat alternative approaches were there?
#1327
But we believe that it's not neccesary since the way Magic Wand works was fixed recently and potentially we don't need async stuff.
This change affects (describe how if yes)
Does this PR introduce a breaking change?
What level of testing was included in the change?
Which logical domain(s) does this change affect?
Multy Image Segmentation,Magic Wand