This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: LEAP-640: Don't save empty draft on View All #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should save draft when user clicks on View All, but we should save it only if there are changes or unsubmitted comment.
Comments are for the next iteration
jombooth
approved these changes
Feb 9, 2024
nikitabelonogov
approved these changes
Feb 9, 2024
MasherJames
pushed a commit
to HelloPareto/label-studio-frontend
that referenced
this pull request
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.) First replace this text with a brief description of what this pull request does. Include reasoning, references, and other thoughts for better understanding.
2.) Then fill in the items below (adding more description if necessary) or remove them if they aren't relevant.
Please read all items and ensure that each section has been filled in OR removed to create more consistent PRs! Thank you!
PR fulfills these requirements
Describe the reason for change
making sure latest changes are included to make sure LSO is building correctly