Skip to content

Commit

Permalink
Add FIXME for kubeflow/pipelines#10914
Browse files Browse the repository at this point in the history
Signed-off-by: Constantin M Adam <[email protected]>
  • Loading branch information
cmadam committed Nov 14, 2024
1 parent fffb630 commit 5547d7f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions transforms/universal/fdedup/kfp_ray/fdedup_wf.py
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ def fuzzydedup(
)
ComponentUtils.add_settings_to_component(execute_signature_calc_job, ONE_WEEK_SEC)
# FIXME: see https://github.com/kubeflow/pipelines/issues/10914
if os.getenv("KFPv2", "0") == "1":
if os.getenv("KFPv2", "0") != "1":
ComponentUtils.set_s3_env_vars_to_component(execute_signature_calc_job, data_s3_access_secret)
ComponentUtils.set_s3_env_vars_to_component(
execute_signature_calc_job, scdata_s3_access_secret, prefix="scdata"
Expand Down Expand Up @@ -314,7 +314,7 @@ def fuzzydedup(
)
ComponentUtils.add_settings_to_component(execute_cluster_analysis_job, ONE_WEEK_SEC)
# FIXME: see https://github.com/kubeflow/pipelines/issues/10914
if os.getenv("KFPv2", "0") == "1":
if os.getenv("KFPv2", "0") != "1":
ComponentUtils.set_s3_env_vars_to_component(execute_cluster_analysis_job, data_s3_access_secret)
execute_cluster_analysis_job.after(compute_cluster_analysis_exec_params)

Expand Down Expand Up @@ -343,7 +343,7 @@ def fuzzydedup(
)
ComponentUtils.add_settings_to_component(execute_get_duplicate_list_job, ONE_WEEK_SEC)
# FIXME: see https://github.com/kubeflow/pipelines/issues/10914
if os.getenv("KFPv2", "0") == "1":
if os.getenv("KFPv2", "0") != "1":
ComponentUtils.set_s3_env_vars_to_component(execute_get_duplicate_list_job, data_s3_access_secret)
execute_get_duplicate_list_job.after(compute_get_duplicate_list_exec_params)

Expand Down Expand Up @@ -375,7 +375,7 @@ def fuzzydedup(
)
ComponentUtils.add_settings_to_component(execute_data_cleaning_job, ONE_WEEK_SEC)
# FIXME: see https://github.com/kubeflow/pipelines/issues/10914
if os.getenv("KFPv2", "0") == "1":
if os.getenv("KFPv2", "0") != "1":
ComponentUtils.set_s3_env_vars_to_component(execute_data_cleaning_job, data_s3_access_secret)
ComponentUtils.set_s3_env_vars_to_component(
execute_data_cleaning_job, dcdata_s3_access_secret, prefix="dcdata"
Expand Down

0 comments on commit 5547d7f

Please sign in to comment.