Add image_pull_secrets paameter to add_settings_to_comp for kfp v2 #915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To address #914 a new param was added to
add_settings_to_component
function.To pass the secret name the following param should be added to
add_settings_to_component
call:Note: image_pull_secrets could not be a pipeline input parameter because they are of type
PipelineParameterChannel
so we get the following error when trying to use them:Related issue number (if any).
#914