Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to Add-ons in the Settings #1656

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

felipeerias
Copy link
Collaborator

Add a button to open the Add-ons page from the Settings, since that is a pretty obvious place to find this functionality.

To avoid messing up the layout of the honeycomb buttons, I've moved the "What's New" button closer to the version details. After some experimentation, I've placed two small buttons on the right side of the Settings window, linking to the Feedback and News pages.

The background of the What's New button becomes highlighted when the details of the new version are available (this replaces the little blue dot that we had before).

I have also simplified the implementation of the hidden shortcut to show the version details. Now it is just a matter of clicking on the app logo or the app name.

Finally, I have also simplified the layout in the Settings window by removing an unneeded LinearLayout and using the parent ConstraintLayout instead.

@felipeerias
Copy link
Collaborator Author

felipeerias commented Dec 6, 2024

This is how the dialog looks when there is new "What's New" information:

Screenshot_com igalia wolvic dev_2024 12 06-20 53 17 419_016

And this is how it looks in the regular state.

Screenshot_com igalia wolvic dev_2024 12 06-20 51 32 799_385

I think that placing the Add-ons link here makes a lot of sense but am not completely convinced about the rest of the layout. What do you think?

@svillar
Copy link
Member

svillar commented Dec 6, 2024

I think that placing the Add-ons link here makes a lot of sense but am not completely convinced about the rest of the layout. What do you think?

I wholeheartedly agree with placing the addons there, now that I see it, it makes total sense to me. Regarding the other two elements I am not convinced either, looks too texty to me (the other elements are big icons)

@felipeerias felipeerias force-pushed the felipeerias/addonsSettings branch from c0ef6e1 to 089a144 Compare December 17, 2024 14:39
Add a button to open the Add-ons page from the Settings, since that
is a pretty obvious place to find this functionality.

To avoid messing up the layout of the honeycomb buttons, I've moved
the "What's New" button closer to the version details. After some
experimentation, I've placed two small buttons on the right side of
the Settings window, linking to the Feedback and News pages.

The background of the What's New button becomes highlighted when the
details of the new version are available (this replaces the little
blue dot that we had before).

I have also simplified the implementation of the hidden shortcut to
show the version details. Now it is just a matter of clicking on the
app logo or the app name.

Finally, I have also simplified the layout in the Settings window by
removing an unneeded LinearLayout and using the parent
ConstraintLayout instead.
@felipeerias felipeerias force-pushed the felipeerias/addonsSettings branch from 089a144 to fb71766 Compare December 17, 2024 14:56
@felipeerias
Copy link
Collaborator Author

I have updated this PR to adjust the visual appearance.

This is how the Settings dialog looks when the "What's new" page for the current version has not been visited yet:

Screenshot_com igalia wolvic dev_2024 12 17-23 58 00 520_505

And this is how it looks otherwise:

Screenshot_com igalia wolvic dev_2024 12 17-23 54 37 373_157

@felipeerias
Copy link
Collaborator Author

More information about the color attributes for the buttons is available at:

https://github.com/material-components/material-components-android/blob/1.9.0/docs/components/Button.md

Copy link
Member

@svillar svillar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to approve it but I found a significant usability issue. If you open the addons from the settings then there is no clear way to exit the addons tab to go back to the normal browsing.

When visiting bookmarks or downloads is different because you see that the button is pressed in the navigation bar (that could be improved with colors too), but in the case of the addons there is no easy and intuitive way to go back. Somehow you have to discover that clicking on the bookmarks button in the nav bar can take you back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants