-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autocomplete REPL #172
base: master
Are you sure you want to change the base?
autocomplete REPL #172
Conversation
Kudos, SonarCloud Quality Gate passed! |
Great work @shivankar-p . Appreciate it, but i have few concerns which will affect us in future: If we can avoid this stuck in the terminal then it would be better. If you see the xonsh, it made a custom terminal but didn’t stop us for using the terminal functionality. It’s on top of it. Xonsh+promptkit make it feel better. We are making terminal as a single point where our user can do everything starting from search to testing the API. So, I hope you understand the design which we were suppose to implement. As of now don’t close the PR. I’ll review it in my local to see any improvement and will make a call. Meanwhile, if you can explore, can we achieve this thing by REPL? |
This is what I meant by REPL(read evaluate print loop). Basically running an infinite loop and taking inputs unless user wants to exit. Something similar to python3 REPL which we get by entering |
I thought about this and I think a REPL is the only solution in which we can implement autocomplete. Because, we have control only over the repl, the other auto completion is controlled by the shell. |
No, REPL is not the only solution. If you see gitsome, those guys were using xonsh as a primary terminal for the customisation and did autocomplete as well. Try installing gitsome and you can see the difference |
Oh, let me take a look |
cc @shivankar-p |
Related Issue
Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
Checklist:
Screenshots