-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the introduction Section when a -st is initiated and added functionality '-v' to check the version #79
base: master
Are you sure you want to change the base?
Improved the introduction Section when a -st is initiated and added functionality '-v' to check the version #79
Conversation
…unctionality '-v' to check the version
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉Congratulations!!🎉 for making your first PR , our mentors will review it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good . But you may capitalize the sentences from lines 52-58(main.py)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please capitalize those words
\U0001F609 See this message again with '-st' | ||
\U00002755 Get help with '-h' | ||
Use the following commands to get started | ||
\U0001F50E to search StackOverflow, type 'dynamic -s' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the Indentation of words for the user to read!
Example:
\U0001F50E to search StackOverflow, type 'dynamic -s'
can be replaced by
\U0001F50E To Search on StackOverflow, type 'dynamic -s'
And, similar till #L58
''') | ||
else: | ||
search_flag.search_args() | ||
search_flag.search_args() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add End of file (EOF)
Just Press Enter Once After #L61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why you converted the sentences into lower case 🤔 . And also please resolve the merge conflicts
Describe the changes you've made
I have added an extra functionality "dynamic -v" to show the version
I have tried to Change the Intro Section of the Dynamic CLI to look and feel like a NPM Package
Checklist:
Screenshots
"dynamic -v " support
Changes in the intro section