Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/fix linting issues #15

Merged
merged 3 commits into from
Sep 21, 2024
Merged

Chore/fix linting issues #15

merged 3 commits into from
Sep 21, 2024

Conversation

Zyruks
Copy link
Member

@Zyruks Zyruks commented Sep 21, 2024

Changes Made 🎉

  • Updated clean script:

    • Updated the clean script in all package.json files to the following:

      • "clean": "git clean -xdf .turbo node_modules dist"
    • This ensures that the .turbo, node_modules, and dist directories are cleaned effectively during development and builds.

    • Fixed linting issue in utility function:

    • Changed the type of value in isNullOrUndefined from any to unknown for better type safety.

  • Fixed linting issue in Button component:

    • Updated the onClick handler in the Button component to use void before calling signIn('twitter') for improved linting and type checking.

Describe Changes

  • Enhanced clean script: The clean script has been updated to ensure complete cleaning of build and dependency directories across all packages.
  • Next.js update: Next.js has been updated to the latest version for improved performance and stability.
  • Utility function update: Refined the type of the value parameter to use unknown instead of any.
  • Button component update: Adjusted the onClick handler to use void for more explicit handling of side effects.

Visual

Linter with warnings

Code_E5vg8bUKMG

After Linter without warnings

Code_Cem3FtWr0E

Checklist ✅

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

…and dist folders

- Updated the `clean` script in all `package.json` files to the following:
  - `"clean": "git clean -xdf .turbo node_modules dist"`
- This ensures that the `.turbo`, `node_modules`, and `dist` directories are cleaned effectively during development and builds.
- Updated Next.js from version `3.4.10` to `3.4.12` for the latest features, improvements, and bug fixes.
@Zyruks Zyruks added the Type: Enhancement Suggest an improvement for an existing feature. label Sep 21, 2024
@Zyruks Zyruks self-assigned this Sep 21, 2024
…onent

- Fixed linting issue in utility function:
  - Changed the type of `value` in `isNullOrUndefined` from `any` to `unknown` to ensure stricter type checking.

- Fixed linting issue in Button component:
  - Updated the `onClick` handler to use `void` with the `signIn` function call for better type safety.
@Zyruks Zyruks force-pushed the chore/fix-linting-issues branch from 9c373cf to 417d5de Compare September 21, 2024 22:32
@Zyruks Zyruks requested a review from serudda September 21, 2024 22:35
@serudda serudda merged commit a6ce3de into main Sep 21, 2024
1 check passed
@serudda serudda deleted the chore/fix-linting-issues branch September 21, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Suggest an improvement for an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants