try to backport the named parameter patch #79
Conversation
|
I'm still not getting the whole arrows example for physics rendered even with this patch.. |
| .get(param_name) | ||
| .map(|pn| self.parameters.get(pn).expect("param index mismatch {pn}")) | ||
| .unwrap_or_else(|| panic!("No parameter named: {}", param_name)); |
There was a problem hiding this comment.
.expect is not a format-like macro, it's just a function. So that {pn} is gonna display as {pn} and not the contents of pn. I suggest either removing that part, or (better solution) make get/set_param return a Result<T, ParamNotFound>, which will automatically also make the methods more resilient like we wanted a few days ago
There was a problem hiding this comment.
Ehh yeah I wasn't paying attention to this so it might already be a Result in the other branch ? I'll check and copy
The inner error is a panic error though, the index having a reference to a non-existent value
|
Just realized parameters already have use the UUID in the |
|
TLDR; I'm not really convinced this should be merged but I'm also not convinced the physics and main branch haven't diverged so much that a rebase will be just as much work as a rewrite |
|
Physics is now fixed on the physics branch, so I think I'll close this |
No description provided.