Remove "Type" from TCoordinateType template parameters, remove initial "T" from TCoordinateType alias
#5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The postfix `Type` is unnecessary for a template parameter, because the prefix letter `T` already indicates that it is a type.
The postfix `Type` is unnecessary for a template parameter, because the prefix letter `T` already indicates that it is a type.
Made the template parameter names in the header files (itk*.h) consistent with the corresponding implementation (itk*.hxx).
In general, `TCoordinate` is used to denote the name of a template parameter for a coordinate type.
In general, we only use the `T` prefix for template parameters, not for aliases.
github-actions
bot
added
type:Testing
|
FYI: FYI: Github actions is having issues: actions/runner#3611 |
jhlegarreta
approved these changes
Dec 5, 2024
dzenanz
approved these changes
Dec 5, 2024
jhlegarreta
merged commit 39f5687
into
InsightSoftwareConsortium:master
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The postfix
Typeis unnecessary for a template parameterTCoordinateType, because its initialTalready indicates that it is a type.On the other hand, a type alias (typedef) "typically" has a
Typepostfix, but should not have aTinitial.Triggered by a comment from Jon (@jhlegarreta) at #4995 (comment)