Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Build manylinux2014 wheels by default #253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tbirdso
Copy link
Contributor

@tbirdso tbirdso commented Feb 27, 2023

Updates default manylinux cross-compilation image from "_2_28" to "2014" which corresponds to toolset downgrade from glibc 2.28+ (Ubuntu 20.04+) to glibc 2.17+ (Ubuntu 18.04+).

This downgrade is made to better address existing community needs. Both "_2_28" and "2014" builds continue to be available and supported.

EDIT: Pending investigation of aarch64 failure in https://github.com/tbirdso/ITKSplitComponents/actions/runs/4284448724/jobs/7461422239

Updates default manylinux cross-compilation image from "_2_28" to "2014"
which corresponds to toolset downgrade from glibc 2.28+ (Ubuntu 20.04+)
to glibc 2.17+ (Ubuntu 18.04+).

This downgrade is made to better address existing community needs. Both
"_2_28" and "2014" builds continue to be available and supported.
@tbirdso tbirdso requested a review from thewtex February 27, 2023 16:36
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tbirdso
Copy link
Contributor Author

tbirdso commented Feb 27, 2023

@thewtex I think the failure is due to only supporting _2_28 for aarch64 builds, hence switching the default from _2_28 to 2014 fails on aarch64. Given the roadmap we discussed today, probably the easiest path forward is to let this sit for now and include it with or after changes to support cross-compilation with manylinux2014-aarch64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants