Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --module input optional #91

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

princejohnsantillan
Copy link

Currently this value is required, example: php artisan make:controller TestController --module=module-1

This PR allows for us to just select it from a list, example: php artisan make:controller TestController --module

CleanShot 2024-04-26 at 10 31 59@2x

@Wulfheart
Copy link
Contributor

This would be so cool!

@ahinkle
Copy link

ahinkle commented May 10, 2024

Nice one! Was looking for this as well.

@Wulfheart
Copy link
Contributor

But we need to account that we want to create something in the /app folder as well.

@ahinkle
Copy link

ahinkle commented May 10, 2024

I'm not sure if I'm following. This PR allows modular and non-modular files to be generated.

php artisan make:model Flight (creates in /app)

php artisan make:model Flight --module

php artisan make:model Flight --module=airport

@princejohnsantillan
Copy link
Author

But we need to account that we want to create something in the /app folder as well.

If you don't add --module it will create it on the app folder by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants