-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite: APNs: Scoped App Tokens #101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note to self: the current receive API relies on the fact that the network is slower to respond than the scheduler is to schedule the receive task, as there is no backlog. |
+ BroadcastStream now has a backlog to eliminate common races + FilteredStream now takes any Filter + Filters are now chainable
notification_stream does NOT automatically ACK, since the stream may later be filtered etc.
The API is finished, it involved developing a new "Stream Filters" mechanism internally, but it leads to a nice clean test like this: @pytest.mark.asyncio
async def test_scoped_token():
async with apns.create_apns_connection(
*await apns.activate(), courier="1-courier.sandbox.push.apple.com"
) as connection:
token = await connection.mint_scoped_token("dev.jjtech.pypush.tests")
test_message = f"test-message-{uuid.uuid4().hex}"
# Not part of pypush, uses Apple's public APNs API
await send_test_notification(token.hex(), test_message.encode())
await connection.expect_notification(
"dev.jjtech.pypush.tests",
token,
lambda c: c if c.payload == test_message.encode() else None,
) |
JJTech0130
commented
May 19, 2024
makes awaiting _connected an implementation detail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows receiving notifications sent from the public APNs API
await connected
API