-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply RemoveTestPrefix (and fix some issues manually) #10799
Conversation
oddEvenLogic(boolean, boolean, boolean, boolean)
org.jabref.logic.citationkeypattern.CitationKeyGeneratorTest authorsAlpha(String, BibEntry, String)
org.jabref.logic.citationstyle.CitationStyleGeneratorTest cslMapping(String, BibDatabaseMode, BibEntry, String)
org.jabref.logic.importer.fileformat.BibtexImporterTest parsingOfEncodedFileWithHeader(Charset, String)
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
As this does not work I would not merge it and close it for the moment to reduce noise |
Note that I marked it as "draft" :) |
I will focus on "RemoveTestPrefix", because this is already a huge change. I fixed the issues mentioned at #10799 (comment). |
GitHub does not like my pushes. Thus keeping the PR closed and re-opening a clean PR. |
Follow-up to #10797
99% of the rewrite worked. I just had to manually exclude some files and make some adaptions (copy three test files, make JavaDoc links full links)
Opened upstream issues:
TestsShouldNotBePublic
should reduce visibility if used elsewhere in Javadoc links openrewrite/rewrite-testing-frameworks#458assertEquals
openrewrite/rewrite-testing-frameworks#459Existing upstream issue: openrewrite/rewrite-testing-frameworks#258
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)