Remove Plane Object
#256
Merged
Remove Plane Object
#256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jammy2211
requested review from
rhayes777,
Sketos,
caoxiaoyue,
qiuhan96,
samlange04 and
kassidy-kollmann
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR set off with the lofty goal of removing the
Planeobject from PyAutoGalaxy and PyAutoLens.This was motivated by a belief that the
Planeobject didn't act as much more than a glorified wrapper of a summation function (e.g. summing together the quantities of individualGalaxyobjects).The refactor started off great, and led to a reduction in code, however as I slowly updated unit tests to make them pass I realised there was a lot of functionality in the
Planeobject that did specific calculations, oops.I then ended up adding a
Galaxiesobject, which analogous to aPlanegroups galaxies to perform various calculations.Overall this PR wasn't a huge success and didn't reduce the amount of code as I'd have liked, but it is improvement on what we had before:
PyAutoGalaxy no longer has this clunky
planeattribute and object floating around, which was really a remnant of it being a spin-off of autolens. Instead, PyAutoGalaxy now only deals withgalaxiesobjects, as it should be!.The API in many parts of the code is more concise, with the removal of
.planesattributes.The PyAutoLens tracer has come out simpler and more concise.
So, overall the refactor was worth while, just.