-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add symlink support #193
Conversation
44a66b9
to
24f7ce8
Compare
Rebased to main. |
@boldandbrad I will review later this week. |
@JanDeDobbeleer I don't remember the linter being upset before I rebased to main (and the only thing that changed in main to my knowledge was the one-line rendering order that was merged in #196). It appears to be upset that I "duplicated" the test setup from the alias_test file to test the symlink functionality. It also wants me to create a constant for the For both of these "errors" I want to make sure I'm following the patterns of the codebase, any suggestions to resolve? No rush at all, I know you've been busy chasing omp install issues. I haven't had much time in the last week to address this either, but still interested in feedback when you get a chance. |
Still in my list, I'll still try to look this week! |
This week turns out to be this week, I'll merge it in the coming days with some adjustments. |
739257b
to
93842f5
Compare
f2e2327
to
5b63028
Compare
27442e3
to
62efe7d
Compare
I just need to test this and we're good to go |
62efe7d
to
6c83abb
Compare
6c83abb
to
4e100a5
Compare
87cce49
to
3f17c03
Compare
3f17c03
to
6392122
Compare
@all-contributors please add @boldandbrad for doc |
I've put up a pull request to add @boldandbrad! 🎉 |
Prerequisites
I've built and tested within my own config using zsh on macOS.
Features
This PR closes #192.
Now you can:
Outstanding issues/considerations
I've defaulted to using
-f
(force) by default since it would be annoying to get notifications at every shell invocation about symlinks already existing. There's probably a better solution where there is a force attribute on Links that defaults to false but can be overridden, or a globalforce-links
config. In addition,cmd
does not have a-f
option formklink
, so additional work might need to be done to remove and replace the symlink if force is actually wanted. I'd like some help determining which approach makes most sense for this tool.Let me know what you think!