Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(devcontainer): prebuild oh my posh #4322

Conversation

warrenbuckley
Copy link
Contributor

@warrenbuckley warrenbuckley commented Oct 6, 2023

Prerequisites

  • I have read and understood the contributing guide.
  • The commit message follows the conventional commits guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

Test Notes

This uses the devcontainer.json property updateContentCommand to run the same command that is the VSCode task named devcontainer: rebuild oh-my-posh
https://containers.dev/implementors/json_reference/#lifecycle-scripts

image

This means we can get straight stuck into development when working inside a GitHub Codespace or locally run Docker DevContainer and not forget why our changes are not working because we forgot to run the task 🙈

  • Spin up a new GitHub Codespace or DevContainer
  • Once CodeSpace is run & open the same command for building it locally is run
  • Go straight to the terminal and run oh-my-posh version

Description

🤖 Generated by Copilot at cc5c4f7

Add a updateContentCommand to devcontainer.json to compile oh-my-posh from source in the devcontainer. This enables testing and debugging the latest changes in the prompt theme engine.

How

🤖 Generated by Copilot at cc5c4f7

  • Add a updateContentCommand property to the devcontainer.json file to automatically compile the oh-my-posh executable from the source code in the devcontainer (link)

@warrenbuckley warrenbuckley force-pushed the feature/devcontainer-prebuild-oh-my-posh branch 3 times, most recently from b963ec3 to 3364cc7 Compare October 6, 2023 15:45
@warrenbuckley warrenbuckley changed the title [feature](devcontainer) prebuild oh my posh feature(devcontainer): prebuild oh my posh Oct 6, 2023
@JanDeDobbeleer JanDeDobbeleer force-pushed the feature/devcontainer-prebuild-oh-my-posh branch from d6ea3e8 to ba0f726 Compare October 13, 2023 09:10
@JanDeDobbeleer JanDeDobbeleer enabled auto-merge (rebase) October 13, 2023 09:11
@JanDeDobbeleer JanDeDobbeleer merged commit 108a836 into JanDeDobbeleer:main Oct 13, 2023
9 checks passed
@warrenbuckley warrenbuckley deleted the feature/devcontainer-prebuild-oh-my-posh branch October 13, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants