Fix For Issue 258 - Thread Safety #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 27, 2021 12:43
…lth check request using Microsoft's OOTB health check service which runs the health check registrations in parallel
…entDictionary to prevent the thread safety race condition from occurring
…o that it more reliably reproduces the problem if a plain Dictionary is used and not a ConcurrentDictionary
|
@RyanThomas73 I'm working this one in today. As usual, sorry for the delay and thank you very much for working through this. The only thing I'm changing is swapping out |
|
It with a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #258
Scope.Servicesproperty to typeConcurrentDictionaryto prevent the thread safety race condition from occurring.Lamar.AspNetCoreTests.Integrationto include a test case that configures and runs a set of health checks, since that is how both reporters on issue 258 have encountered the issue.