-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for raspberry pi pico #143
Support for raspberry pi pico #143
Conversation
Any reason why this hasn't been merged yet? Seems to provide all basic necessary features, and looks good. |
I will give it once-over and check with my Pico in a couple of days. Sorry for the long delay, only got some spare time back recently. |
Completely understand that! Was just curious to see if there was a major issue here or not. Thanks! |
I have verified that it works with my "vanilla" Raspberry Pi Pico. Thank you for helping with this! |
@timsavage I haven't checked that you signed the CLA before merging. :( I'll have to revert until I get the confirmation that it has been signed. Sorry for the hassle! |
@lensvol Let me know what needs to be signed off, happy to do that. |
@timsavage Could you please visit https://www.jetbrains.com/agreements/cla/ and electronically sign the contributor license agreement? After that PR will be marked as "CLA Signed" and I will re-introduce your changes into the codebase. :) I apologize for the inconvenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@lensvol BTW Do you think we should add "Make sure you've signed the CLA" step with the comment on how to do it to our Source Code section of the README.md? |
Have signed the CLA. |
@timsavage Thank you! |
Yes, alongside with "Please check if there is already a pull request that solves the same problem". We've had quite a few duplicate ones recently, would not hurt to explicitly mention this as well. In addition to updating |
Adds support for the Raspberry Pi Pico board.
Type hints are "best effort" at this point, I have reverse engineered what I could from the available documentation and poking about in the REPL. These API's are also under development, even the official docs are not always correct.
Covers #132