Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for raspberry pi pico #143

Merged
merged 6 commits into from
Apr 16, 2021
Merged

Support for raspberry pi pico #143

merged 6 commits into from
Apr 16, 2021

Conversation

timsavage
Copy link
Contributor

@timsavage timsavage commented Feb 20, 2021

Adds support for the Raspberry Pi Pico board.

  • Is autodetected via its USB identifiers
  • REPL works
  • Uploading files works

Type hints are "best effort" at this point, I have reverse engineered what I could from the available documentation and poking about in the REPL. These API's are also under development, even the official docs are not always correct.

Covers #132

@timsavage timsavage changed the title Initial Support for raspberry pi pico Support for raspberry pi pico Feb 20, 2021
@TheCatster
Copy link

TheCatster commented Apr 13, 2021

Any reason why this hasn't been merged yet? Seems to provide all basic necessary features, and looks good.

@lensvol
Copy link
Collaborator

lensvol commented Apr 14, 2021

Any reason why this hasn't been merged yet? Seems to provide all basic necessary features, and looks good.

I will give it once-over and check with my Pico in a couple of days. Sorry for the long delay, only got some spare time back recently.

@TheCatster
Copy link

Sorry for the long delay, only got some spare time back recently.

Completely understand that! Was just curious to see if there was a major issue here or not. Thanks!

@lensvol
Copy link
Collaborator

lensvol commented Apr 15, 2021

I have verified that it works with my "vanilla" Raspberry Pi Pico.

Thank you for helping with this!

@lensvol lensvol merged commit 0bb3dd5 into JetBrains:master Apr 16, 2021
@lensvol
Copy link
Collaborator

lensvol commented Apr 16, 2021

@timsavage I haven't checked that you signed the CLA before merging. :(

I'll have to revert until I get the confirmation that it has been signed. Sorry for the hassle!

@timsavage
Copy link
Contributor Author

@lensvol Let me know what needs to be signed off, happy to do that.

@lensvol
Copy link
Collaborator

lensvol commented Apr 16, 2021

@timsavage Could you please visit https://www.jetbrains.com/agreements/cla/ and electronically sign the contributor license agreement? After that PR will be marked as "CLA Signed" and I will re-introduce your changes into the codebase. :)

I apologize for the inconvenience.

Copy link
Contributor

@vlasovskikh vlasovskikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@vlasovskikh
Copy link
Contributor

@lensvol BTW Do you think we should add "Make sure you've signed the CLA" step with the comment on how to do it to our Source Code section of the README.md?

@timsavage
Copy link
Contributor Author

Have signed the CLA.

@vlasovskikh
Copy link
Contributor

@timsavage Thank you!

@lensvol
Copy link
Collaborator

lensvol commented Apr 17, 2021

@lensvol BTW Do you think we should add "Make sure you've signed the CLA" step with the comment on how to do it to our Source Code section of the README.md?

Yes, alongside with "Please check if there is already a pull request that solves the same problem". We've had quite a few duplicate ones recently, would not hurt to explicitly mention this as well.

In addition to updating README.md we can also make a template for the pull request with a similar checklist. :)

@timsavage timsavage deleted the feature/support-for-raspberry-pi-pico branch August 5, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants