Clarified documentation for kotlin compilation with maven plugin #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mipo256, Thank you for your contribution to the Kotlin documentation! We really appreciate it. Right now, the technical writing team is busy preparing for the upcoming Kotlin 2.1.0 release, so we won't be able to review your PR within the next two weeks. Apologies for the inconvenience. We'll get back to your PR as soon as possible. In the meantime, it would be great if you could review the Kotlin documentation style guide and apply it to your contribution. Thanks in advance, and we look forward to reviewing your changes! |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for compilation of Kotlin projects along with Java code via Maven plugin is a bit obscure. The technique that is used is actually quite sophisticated, and it is not clear for an average reader why it works, why disabling native executions and re-declaring them, and why it is important to have kotlin plugin before maven compiler plugin.
To address this, I've contributed the detailed explanation about what is going on and why it works.