Skip to content

Commit

Permalink
Skip Aqua stale deps check in downstream tests (#398)
Browse files Browse the repository at this point in the history
  • Loading branch information
jishnub authored Dec 3, 2024
1 parent 6631f07 commit 295266c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/downstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
# force it to use this PR's version of the package
Pkg.develop(PackageSpec(path=".")) # resolver may fail with main deps
Pkg.update()
Pkg.test(; coverage = true) # resolver may fail with test time deps
Pkg.test(; coverage = true, test_args=["--downstream_integration_test"]) # resolver may fail with test time deps
catch err
err isa Pkg.Resolve.ResolverError || rethrow()
# If we can't resolve that means this is incompatible by SemVer and this is fine
Expand Down
2 changes: 2 additions & 0 deletions test/aqua.jl
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
using Aqua
using FillArrays
using Test
downstream_test = "--downstream_integration_test" in ARGS
@testset "Project quality" begin
Aqua.test_all(FillArrays;
# https://github.com/JuliaArrays/FillArrays.jl/issues/105#issuecomment-1582516319
ambiguities=(; broken=true),
stale_deps = !downstream_test,
)
end

0 comments on commit 295266c

Please sign in to comment.