add jl_expand_in_world #37902
Merged
add jl_expand_in_world #37902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
breaking
vtjnash
reviewed
Oct 6, 2020
vtjnash
removed
breaking
Co-authored-by: Jameson Nash <[email protected]>
c42f
approved these changes
Oct 7, 2020
There was a problem hiding this comment.
This seems pretty straightforward, I think it's fine to merge 👍
I kinda wish we could piggyback this off invoke_in_world somehow, but it's not clear to me how this would work: Normally it's important that eval() and expansion just default to the latest world, rather than following the dynamically scoped world age of the function call tree.
|
Unless there's any objections, I'll merge this tomorrow (ping me if I forget). |
JeffBezanson
reviewed
Oct 7, 2020
Co-authored-by: Jeff Bezanson <[email protected]>
|
The bad test looks fixed now, is this good to get merged? |
|
The freebsd test failure is a timeout. Looks like other unrelated builds are suffering from that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specifying a particular worldage for macro expansion. Needed for fixing timholy/Revise.jl#552.
cc @timholy, @c42f