-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU Support in Field Calculations #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only one hardcoded case of boundary conditions for now.
lmh91
added
enhancement
Improvement of existing features
performance
Performance improvements
labels
Oct 9, 2021
lmh91
force-pushed
the
gpu_sor
branch
4 times, most recently
from
October 14, 2021 12:47
f772730
to
e251056
Compare
lmh91
changed the title
[WIP] GPU Support in Field Calculations
GPU Support in Field Calculations
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPU Support for the SOR Field Calculation
In this PR I added GPU Support for the field calculations via KernelAbstractions.jl and it will close #60.
So far I just implemented it for cylindrical coordinates and depletion handling is not yet enabled for the GPU backend.
ToDo for this PR:
Not necessarily in this PR
Note:
There was also one change regarding the CPU implementation of the SOR:
After each iteration all grid points values at
r = 0
were averaged (since they are in principle the same points).Now, this is only done once at the very end.
I don't think doing it after each iteration is not necessary (tests still pass) (they anyhow converge against the same value within numerical precision) and I now removed it since otherwise I would need to add an extra kernel function (GPU) for it.
It includes also a small bugfix in the depletion handling on the CPU backend.