Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WB-1814: Switch to semantic color tokens #2401

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

WB-1814: Switch to semantic color tokens #2401

wants to merge 5 commits into from

Conversation

jandrade
Copy link
Member

Summary:

This PR switches the color tokens used in components to the new semantic color
tokens.

  • Migrated Accordion, Banner, and BirtdayPicker.

Issue: https://khanacademy.atlassian.net/browse/WB-1814

Test plan:

Verify that the visual regression tests don't show any changes.

@jandrade jandrade self-assigned this Dec 17, 2024
Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 167acfc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@khanacademy/wonder-blocks-birthday-picker Patch
@khanacademy/wonder-blocks-accordion Patch
@khanacademy/wonder-blocks-banner Patch
@khanacademy/wonder-blocks-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 17, 2024

Size Change: +77 B (+0.08%)

Total Size: 97.1 kB

Filename Size Change
packages/wonder-blocks-accordion/dist/es/index.js 3.74 kB -25 B (-0.66%)
packages/wonder-blocks-banner/dist/es/index.js 1.55 kB +28 B (+1.83%)
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.8 kB +30 B (+1.69%)
packages/wonder-blocks-button/dist/es/index.js 4.08 kB +44 B (+1.09%)
ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-breadcrumbs/dist/es/index.js 887 B
packages/wonder-blocks-cell/dist/es/index.js 2.01 kB
packages/wonder-blocks-clickable/dist/es/index.js 3.06 kB
packages/wonder-blocks-core/dist/es/index.js 3.52 kB
packages/wonder-blocks-data/dist/es/index.js 6.24 kB
packages/wonder-blocks-dropdown/dist/es/index.js 19.1 kB
packages/wonder-blocks-form/dist/es/index.js 6.2 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-icon-button/dist/es/index.js 2.95 kB
packages/wonder-blocks-icon/dist/es/index.js 871 B
packages/wonder-blocks-labeled-field/dist/es/index.js 72 B
packages/wonder-blocks-layout/dist/es/index.js 1.82 kB
packages/wonder-blocks-link/dist/es/index.js 2.28 kB
packages/wonder-blocks-modal/dist/es/index.js 5.42 kB
packages/wonder-blocks-pill/dist/es/index.js 1.65 kB
packages/wonder-blocks-popover/dist/es/index.js 4.85 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.52 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.36 kB
packages/wonder-blocks-switch/dist/es/index.js 1.92 kB
packages/wonder-blocks-testing-core/dist/es/index.js 3.74 kB
packages/wonder-blocks-testing/dist/es/index.js 1.07 kB
packages/wonder-blocks-theming/dist/es/index.js 693 B
packages/wonder-blocks-timing/dist/es/index.js 1.8 kB
packages/wonder-blocks-tokens/dist/es/index.js 2.36 kB
packages/wonder-blocks-toolbar/dist/es/index.js 905 B
packages/wonder-blocks-tooltip/dist/es/index.js 6.99 kB
packages/wonder-blocks-typography/dist/es/index.js 1.23 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Dec 17, 2024

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-izowstmmit.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 377
Tests with visual changes 2
Total stories 515
Inherited (not captured) snapshots [TurboSnap] 0
Tests on the build 377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant