Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shading language support] Remove shader variants and reflection for ARM framework samples #1107

Open
SaschaWillems opened this issue Jul 20, 2024 · 0 comments
Assignees
Labels
framework This is relevant to the framework hlsl Everything related to getting HLSL support added

Comments

@SaschaWillems
Copy link
Collaborator

The ARM framework currently uses a few shader variants and along with that reflection to map shader inputs to the C++ side of things. That is contrary to the api framework samples, where every sample uses it's own set of shaders and no runtime reflection-

This prevents us from adding support for offline compiled shaders and HLSL shader support to the ARM framework samples-

We should completely remove shader variants and replace them with explicit shaders per sample instead.

Examples are most of the shaders in the shader root directory, e.g.:

  • base.frag
  • base.vert
  • lighting.h
  • pbr.frag
  • pbr.vert

These should be moved to explicit per-sample folders and adjusted per sample so that we no longer need variants and runtime reflection.

@SaschaWillems SaschaWillems changed the title [Shading language support] Remove shader variants and reflections [Shading language support] Remove shader variants and reflections for ARM framework samples Jul 20, 2024
@SaschaWillems SaschaWillems changed the title [Shading language support] Remove shader variants and reflections for ARM framework samples [Shading language support] Remove shader variants and reflection for ARM framework samples Jul 20, 2024
@SaschaWillems SaschaWillems added framework This is relevant to the framework hlsl Everything related to getting HLSL support added labels Jul 20, 2024
@tomadamatkinson tomadamatkinson self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework This is relevant to the framework hlsl Everything related to getting HLSL support added
Projects
None yet
Development

No branches or pull requests

2 participants