Louder Windows codesign errors #4762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4762 +/- ##
=======================================
Coverage 85.83% 85.83%
=======================================
Files 86 86
Lines 30939 30939
=======================================
Hits 26555 26555
Misses 4384 4384
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pierremtb
changed the title
pierremtb
commented
Jan 3, 2025
| @@ -38,7 +38,7 @@ win: | |||
| # - arm64 | |||
| signingHashAlgorithms: | |||
| - sha256 | |||
| sign: "./sign-win.js" | |||
There was a problem hiding this comment.
Took the opportunity to move this script to where the other scripts are instead of repo root since I was testing it.
nadr0
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4582
Throws an error instead of just logging and continuing with green status.
When it silently failed a few weeks ago:
Versus on this branch: (fake throw)
