Fix fuzz crate lints and update deps #4873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
force-pushed
the
jtran/fix-fuzz-lints
branch
from
368c85a to
52dd92f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4873 +/- ##
=======================================
Coverage 85.84% 85.84%
=======================================
Files 86 86
Lines 30946 30946
=======================================
Hits 26566 26566
Misses 4380 4380
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nadr0
approved these changes
Jan 2, 2025
jtran
added a commit
that referenced
this pull request
Jan 2, 2025
* Fix fuzz to use new API * Fix fuzz Cargo.toml lints and update lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since adding workspace lints in #4665, the fuzz crate has been broken. It isn't part of the workspace. When I fixed this, cargo decided that lots of libraries needed updating.
Also, the parser fuzz target was using the old parser API. So I updated that too.