Move the base CodeMirror KCL support to a local package #4876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This separates the base language support from the LSP and color picker.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move the basics of the CodeMirror KCL support into
packages/codemirror-lang-kcl.The basics excludes the LSP additions and the color picker extension.
Why
Trying to make it easier for other projects to use the KCL support. The idea is that this eventually leads to a
@kittycad/codemirror-lang-kclon npmjs.Also hoping this makes it easier for people to contribute. For example most CM lang packages have this cases.txt style test setup for verifying changes.
References
Closes #4868
Similar to /pull/2846 for
codemirror-lsp-client.