Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test for foreign characters in project name #4976

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Jan 8, 2025

part of #4975

Copy link

qa-wolf bot commented Jan 8, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jan 8, 2025 2:34am

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.86%. Comparing base (a9ceaf2) to head (d7229ba).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4976   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files          86       86           
  Lines       31081    31081           
=======================================
  Hits        26689    26689           
  Misses       4392     4392           
Flag Coverage Δ
wasm-lib 85.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz marked this pull request as ready for review January 8, 2025 02:55
@jessfraz jessfraz requested a review from lf94 January 8, 2025 02:55
@jessfraz jessfraz enabled auto-merge (squash) January 8, 2025 02:56
Copy link
Collaborator

@pierremtb pierremtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Tested locally on windows machine. Looks good!

@jessfraz jessfraz merged commit f89d191 into main Jan 8, 2025
30 checks passed
@jessfraz jessfraz deleted the test-for-weird-characters-in-path branch January 8, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants