Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vtkclipclosedsurface): fix initialization of a bidimensional array #3201

Merged
merged 2 commits into from
Jan 2, 2025
Merged

fix(vtkclipclosedsurface): fix initialization of a bidimensional array #3201

merged 2 commits into from
Jan 2, 2025

Conversation

rodrigobasilio2022
Copy link
Contributor

@rodrigobasilio2022 rodrigobasilio2022 commented Jan 2, 2025 •
edited
Loading

Context

Fix a small bug in vtkClipClosedSurface, referring a wrong bidimensional array initialization.

image

It causes a lot of bugs previously in Cornerstone3D, and the vtkClipClosedSurface was removed

cornerstonejs/cornerstone3D#1046

but it seems that it will be needed for future developments

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@rodrigobasilio2022
Copy link
Contributor Author

@finetjul

finetjul
finetjul approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@floryst floryst added this pull request to the merge queue Jan 2, 2025
Merged via the queue into Kitware:master with commit 35a9338 Jan 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigobasilio2022 @finetjul @floryst