Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - target api 34 and add support for AGP 8 #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature - target api 34 and add support for AGP 8 #36

wants to merge 2 commits into from

Conversation

Timi-Duban
Copy link

Target android api 34 to be compatible with Play Store requirements, and add commit adapted from @AndreiCalazans work found in another project

Change to support AGP 8 as mentioned here: react-native-community/discussions-and-proposals#671

This does not remove package attribute from AndroidManifest to not lose compatibility with AGP < 8 (React Native < 0.71 versions).

I don't think it's worth maintaining logic to remove that attribute contitionally since it will only cause a warning to users on AGP 8 and above.

@Timi-Duban Timi-Duban force-pushed the feature/add-agp8-support branch from 82488d3 to 00682db Compare August 7, 2024 09:38
@Timi-Duban Timi-Duban force-pushed the feature/add-agp8-support branch from 00682db to fd5cbe1 Compare August 7, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Timi-Duban