-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc: use xdg-open for the show in finder command #2584
base: master
Are you sure you want to change the base?
Conversation
fixed Komodo#250 Signed-off-by: Defman21 <[email protected]>
If you do use xdg-open; there's no need to keep the Nautilus/Doplhin options. As every Linux DE out there follows free-desktop standards and so by using xdg-open it will open the default file manager no matter which DE you're using |
Signed-off-by: Defman21 <[email protected]>
Why did you remove the fallbacks? Those are still very relevant. Edit: just read @bil-elmoussaoui 's response. I don't agree with this, this is Linux. We should not make assumptions, |
@Naatan
|
xdg-open would be called first so as long as you have it on your $PATH, Komodo would call it and if it does not exist, call something else. (e.g. Nautilus). @Naatan those 2 file managers does not cover most popular DE's. I think it's better to add a list of some popular file managers and search for them on the PATH rather than doing if-else for DE's. What do you think? :) UPD: oops, that was in the initial fix. I'll add more managers and revert my latest change tomorrow so we'd have some fallbacks. |
It's not about it not working, it's about it being available. There is no reason to not have a fallback, it costs us nothing. |
Signed-off-by: Defman21 [email protected]
Fixed #250